Skip to content

Fix #1267 - update externals/xml2json to v1.2

Vinay Rosenberg requested to merge github/fork/davemevans/1267 into development

Created by: davemevans

See #1267 (closed) for discussion.

Thanks to @bwidtmann and his team for doing some testing which appears to be positive.

Reviewing this change will be very hard even with whitespace supression turned on (ninja tip: add ?w=1 to any diff URL) but I'd appreciate a once over from people. I suppose you could argue that we never bother reviewing any other dependencies, so you could ignore xml2json and just check the handful of touch points in our code.

Most important is that as many people test as possible. Perhaps we should merge into dev branch asap and see if anyone finds anything before next release - this can be backed out easily if needs be.

Merge request reports