instanceof HTMLMediaElement failfast messes up with MSE polyfill

Created by: AxelDelmas

Is it actually necessary to run this check ?

It fails if we pass a polyfill. We used to work around this by making our polyfill inherit from HTMLMediaElement, but this change causes an exception, as some checks are run in HTMLMediaElement's src setter.

See corresponding fmse issue here: https://github.com/streamroot/fmse/issues/9

Created by: dsparacio

prob not a big deal to pull out for your polyfil but I would ask that you do it and test it well please.

Created by: AxelDelmas

Sure, should I just remove this block: https://github.com/Dash-Industry-Forum/dash.js/blob/development/src/streaming/utils/Capabilities.js#L65-L67 ?

Are there any unit check / sample pages that use this and that I should be aware of ? Seems to be used only here, so I think we can safely remove the block and assume that the user will pass an instance of video tag, or knows what he's doing. I can also log a warning instead of throwing, rather than removing the if block altogether.

Created by: dsparacio

Yeah it is just used in that once place I think we are safe here.

Created by: davemevans

This was fixed in 2.1.0 right?

Created by: dsparacio

I believe so with PR #1312