Skip to content

clean up minBufferTime in BufferController

Vinay Rosenberg requested to merge github/fork/streamroot/minBufferTime into development

Created by: AxelDelmas

Cleaned up leftovers around minBufferTime in BufferController:

  • public getter and setter were unused
  • the only part of the code where it was used was here
  • it was only set to manifestInfo.minBufferTime here

⚠ WARNING:

  • the setTimeout was never executed because clearBuffer(getClearRange()) is not not a function. My pull request will allow it to execute again but it might have side effects if this behavior was actually not wanted anymore (not tested)
  • I set the timeout delay to streamProcessor.getStreamInfo().manifestInfo.minBufferTime * 1000 because that's what it was set at in practice. I don't really understand this value as it seems we only get in that part of the code if we're about to trigger a QUOTA_EXCEEDED_ERROR on MSE, so why not do another round of cleaning right away?
  • Additionally to last point, I didn't check if streamProcessor.getStreamInfo().manifestInfo.minBufferTime was always defined when we got in that part of the code. I suppose it is, but why not set this timeout delay to a short and constant amount of time?

Merge request reports