Fix #1517 - don't assume sidx is at offset zero in byte range (!1520) · Merge requests · Vinay Rosenberg / dash-js · GitLab

GitLab now enforces expiry dates on tokens that originally had no set expiration date. Those tokens were given an expiration date of one year later. Please review your personal access tokens, project access tokens, and group access tokens to ensure you are aware of upcoming expirations. Administrators of GitLab can find more information on how to identify and mitigate interruption in our documentation.

Vinay Rosenberg requested to merge github/fork/davemevans/1517 into development Jul 28, 2016

Created by: davemevans

When the indexRange is unknown, dash.js will search for the sidx box. It possibly won't be at the start of the byte range.

This has been proven to fix loading of:

http://dash.edgesuite.net/dash264/TestCasesMCA/dolby/1/1/ChID_voices_51_256_ddp.mpd

and proven not to break the following test vectors

http://dash.edgesuite.net/dash264/TestCases/1a/sony/SNE_DASH_SD_CASE1A_REVISED.mpd (SegmentBase, no indexRange),
http://dash.edgesuite.net/dash264/TestCases/4b/qualcomm/1/ED_OnDemand_5SecSeg_Subtitles.mpd (SegmentBase, indexRange and indexRangeExact='true' both present), and
http://dash.edgesuite.net/dash264/TestCasesHEVC/1a/1/TOS_OnDemand_HEVC_MultiRate.mpd (SegmentBase, indexRange and indexRangeExact='true' both present, and Initialization@range present)

indexRange is mandated by the DASHIF IOP so this problem should never occur in compliant presentations.