Fix MetricsReporting - pass correct config to ReportingFactory (!2254) · Merge requests · Vinay Rosenberg / dash-js · GitLab

GitLab now enforces expiry dates on tokens that originally had no set expiration date. Those tokens were given an expiration date of one year later. Please review your personal access tokens, project access tokens, and group access tokens to ensure you are aware of upcoming expirations. Administrators of GitLab can find more information on how to identify and mitigate interruption in our documentation.

Vinay Rosenberg requested to merge github/fork/davemevans/FixMetrics into development Oct 25, 2017

Created by: davemevans

https://github.com/Dash-Industry-Forum/dash.js/pull/2154 (specifically https://github.com/Dash-Industry-Forum/dash.js/commit/e6a1a4ffa6fd55f0f3e44bf74aaf3bed0c632c38) broke metric reporting because it did not pass MetricsConstants to all necessary modules - ReportingFactory and the modules it creates require this config.

I also changed some let to const whilst there.