Skip to content

Fix ES5 Incompatibility in Controlbar

Vinay Rosenberg requested to merge github/fork/chrishalebarnes/fix-controlbar-es5-incompatibility into development

Created by: chrishalebarnes

Fixed an ES5 incompatibility where let was used instead of var. Since this file is not compiled it needs to stay compatible with ES5 assuming that is the target. When running this file through the uglify minifier, it throws an error since it thinks this is a syntax error.

I'm not entirely sure what compatibility is expected for controlbar.js, but this seemed like a reasonable assumption since the file is not compiled. The change was so small I went ahead and opened this PR instead of an issue first.

Thanks!

Semi-related, this is the PR where let came from https://github.com/Dash-Industry-Forum/dash.js/pull/2520

Merge request reports