Fix issue with captions and subs atom box (!2785) · Merge requests · Vinay Rosenberg / dash-js · GitLab

GitLab now enforces expiry dates on tokens that originally had no set expiration date. Those tokens were given an expiration date of one year later. Please review your personal access tokens, project access tokens, and group access tokens to ensure you are aware of upcoming expirations. Administrators of GitLab can find more information on how to identify and mitigate interruption in our documentation.

Vinay Rosenberg requested to merge github/fork/epiclabsDASH/captions_fix into development Sep 26, 2018

Created by: epiclabsDASH

This PR fixes an issue reported by @Gontran-Molotov and related with captioning. Couple of changes included:

Fix in FragmentTextBoxParser when using subs atoms. Some times, when samples length was higher than subsamples one, an exception was raised because we were trying to read out of subsamples array bounds.
Fix the way we calculate firstFragmentedSubtitleStart. If first timestamp was exactly 0 we were not initializing first timestamp correctly and then the time offset used for deciding when to show each caption was wrong.