Skip to content

Bug fix about id type of mediaInfo for subtitles

Vinay Rosenberg requested to merge github/fork/Orange-OpenSource/mediaInfoIdTypeBugFix into development

Created by: nicosang

Hi,

this PR has to solve an issue found in the attached manifest. manifest.zip

Id of the mediaInfo object is an unsigned int because it's an attribute of AdaptationSet :

<!-- Adaptation Set --> <xs:complexType name="AdaptationSetType"> <xs:complexContent> <xs:extension base="RepresentationBaseType"> <xs:sequence> <xs:element name="Accessibility" type="DescriptorType" minOccurs="0" maxOccurs="unbounded"/> <xs:element name="Role" type="DescriptorType" minOccurs="0" maxOccurs="unbounded"/> <xs:element name="Rating" type="DescriptorType" minOccurs="0" maxOccurs="unbounded"/> <xs:element name="Viewpoint" type="DescriptorType" minOccurs="0" maxOccurs="unbounded"/> <xs:element name="ContentComponent" type="ContentComponentType" minOccurs="0" maxOccurs="unbounded"/> <xs:element name="BaseURL" type="BaseURLType" minOccurs="0" maxOccurs="unbounded"/> <xs:element name="SegmentBase" type="SegmentBaseType" minOccurs="0"/> <xs:element name="SegmentList" type="SegmentListType" minOccurs="0"/> <xs:element name="SegmentTemplate" type="SegmentTemplateType" minOccurs="0"/> <xs:element name="Representation" type="RepresentationType" minOccurs="0" maxOccurs="unbounded"/> </xs:sequence> <xs:attribute ref="xlink:href"/> <xs:attribute ref="xlink:actuate" default="onRequest"/> <xs:attribute name="id" type="xs:unsignedInt"/>

In case of embedded subtitles, this attribute contains 'CC1', 'CC2','CC3' or 'CC4' string values. So, in TextSourceBuffer, we have to check the type of this attribute.

Nico

Merge request reports