Skip to content

Remove settings methods from MediaPlayer

Vinay Rosenberg requested to merge github/fork/epiclabsDASH/configv2-mediaplayer into development

Created by: epiclabsDASH

Second phase of changes related with new configuration mechanism for dash.js. We are removing all configuration methods from MediaPlayer, reducing its size and number of methods, and making simpler adding new setting properties (less chained functions).

In this second phase I am removing deprecated methods from MediaPlayer, fixing unit tests, control bar and updating sample source code, included the Dash.js reference player. Typings have also been updated. dash.js package size reduced by 7Kb.

Pending work:

  • Further review of unit tests. Unit tests of settings should be in its own spec.js file. Currently unit tests of settings are placed within MediaPlayer unit tests.
  • Check if makes sense moving text configuration methods to settings (setTextDefaultLanguage, enableForcedTextStreaming).
  • Check if makes sense moving TrackSwitchMode and SelectionModeForInitialTrack methods to settings.
  • Documentation. Create a wiki page explaining how to consume the new settings api.

Merge request reports