Skip to content

Proper check for absolute url's

Vinay Rosenberg requested to merge github/fork/wesleytodd/https-support into development

Created by: wesleytodd

There are two places were url's are being checked against the string http://. This fixes that so that absolute url's of any sort will be correctly detected.

I tried to add a unit test for this but it seems like that whole file would have to be refactored to give access to that function. If there is another way I would be happy to add a test for this.

Also, there is a second place where the http is being hardcoded but I could not find a way to get it to run, so I left it. That is here https://github.com/Dash-Industry-Forum/dash.js/blob/development/app/js/dash/DashParser.js#L254

And here is my signed agreement: dash-if-feedback-agreement-3-7-2014

Merge request reports