Skip to content

types: allowing partial definition of setting obj

Vinay Rosenberg requested to merge github/fork/adripanico/development into development

Created by: adripanico

The current definition of MediaPlayerSettingClass included in index.d.ts file causes that the TypeScript transpiler ask you to define the whole object while calling to updateSettings method of the MediaPlayerClass.

According to the documentation (http://cdn.dashjs.org/latest/jsdoc/module-MediaPlayer.html):

updateSettings(settingsObj) Update the current settings object being used on the player. Anything left unspecified is not modified.

This function does not update the entire object, only properties in the passed in object are updated.

This PR set all the parameters of MediaPlayerSettingClass as optional parameters, so the user is able to define only the parameters s/he want to change.

Merge request reports