Skip to content

DashMetrics

Vinay Rosenberg requested to merge github/fork/Orange-OpenSource/dash-metrics into development

Created by: bbert

The goal of PR is to fix the DashMetrics class and its type declaration:

  • add the method getCurrentBufferState()
  • remove the method getLatestBufferInfoVO
  • update types declaration

Questions (@epiclabsDASH ?):

  • what's the use for the readonly parameter in DashMetrics methods? From outside dash.js, shouldn't it always be fixed to 'true'?
  • why the input media type for DashMetrics methods is only either 'video', 'audio', or 'image'?
  • more generally, in types declaration file, in many methods all possible media types are described (for example type: 'video' | 'audio' | 'fragmentedText'). why not declaring a general type "MediaType", to be used by all methods?

Merge request reports