Skip to content

getSegmentForTime is returning indicies off by one segment

Vinay Rosenberg requested to merge github/fork/bbc/getSegmentForTimeBug into development

Created by: robertbryer

When replacement fragments are requested by ScheduleController, they flow into the getSegmentsForTime function in the templateSegmentsGetter. This function is returning indicies off by one, so replacement fragments would be ordered for the segment before what was wanted.

To reproduce: Invoke a replacement by suddenly throttling and getting the abandon rule to abandon a high quality segment. See that the replacement segment ordered is one segment early.

This PR removes the -1 that made the calculation from time incorrect.

Merge request reports